-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changement de conditions de synchronisation des DDB vers le crm brevo #1622
Open
madjid-asa
wants to merge
6
commits into
master
Choose a base branch
from
madjid-asa/improve-sync-brevo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guilouf
reviewed
Jan 2, 2025
madjid-asa
commented
Jan 2, 2025
Comment on lines
+263
to
+274
proj_resulted_in_reserved_tender = forms.BooleanField( | ||
widget=forms.CheckboxInput(), | ||
required=False, | ||
label=Tender._meta.get_field("proj_resulted_in_reserved_tender").verbose_name, | ||
) | ||
|
||
is_reserved_tender = forms.BooleanField( | ||
widget=forms.CheckboxInput(), | ||
required=False, | ||
label=Tender._meta.get_field("is_reserved_tender").verbose_name, | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça sort un peu du cadre de la PR mais c'est un petit quick win pour faciliter la saisie pour les bizdev
Guilouf
reviewed
Jan 3, 2025
Guilouf
reviewed
Jan 3, 2025
madjid-asa
force-pushed
the
madjid-asa/improve-sync-brevo
branch
from
January 7, 2025 09:15
82b1a9d
to
0b66557
Compare
improve display of tender form admin
madjid-asa
force-pushed
the
madjid-asa/improve-sync-brevo
branch
from
January 7, 2025 09:30
0b66557
to
3e5dad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Changement de conditions de synchronisation des DDB vers le crm brevo. Au lieu de synchroniser par rapport au montant, on synchronise juste si l'attribut
is_followed_by_us=True
Pourquoi ?
Certains cas sont compliqué à jugé sur le prix dans un premier temps.